Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct syntax of canary setMirrorRoute's value #2431

Merged
merged 1 commit into from
Nov 28, 2022
Merged

docs: correct syntax of canary setMirrorRoute's value #2431

merged 1 commit into from
Nov 28, 2022

Conversation

S0n98
Copy link
Contributor

@S0n98 S0n98 commented Nov 23, 2022

Fix wrong syntax of
spec.strategy.canary.steps[setMirrorRoute].match.path.regex and spec.strategy.canary.steps[setMirrorRoute].match.path.prefix

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@S0n98
docs: correct syntax of canary setMirrorRoute's value
c552fdc 
Fix wrong syntax of
spec.strategy.canary.steps[setMirrorRoute].match.path.regex and
spec.strategy.canary.steps[setMirrorRoute].match.path.prefix
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022 •
edited
Loading

E2E Tests Published Test Results

    2 files      2 suites   1h 41m 23s ⏱️
  89 tests   80 ✔️ 3 💤 6 ❌
186 runs  172 ✔️ 6 💤 8 ❌

For more details on these failures, see this check.

Results for commit c552fdc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Go Published Test Results

1 798 tests   1 798 ✔️  2m 31s ⏱️
   102 suites         0 💤
       1 files           0 ❌

Results for commit c552fdc.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 81.55% // Head: 81.55% // No change to project coverage 👍

Coverage data is based on head (c552fdc) compared to base (8987009).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2431   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files         124      124           
  Lines       18931    18931           
=======================================
  Hits        15439    15439           
  Misses       2702     2702           
  Partials      790      790

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit be987f3 into argoproj:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S0n98 @zachaller